[styles] Improve Jest snapshot testing#14358
Closed
jesusmaldonado wants to merge 1 commit into
Closed
Conversation
jesusmaldonado
changed the title
jesusmaldonado
force-pushed
the
removes_counter_testing
branch
from
January 31, 2019 01:40
d43443a to
121b448
Compare
|
|
||
| // For testing, MUI produces duplicate results for Snapshots | ||
|
|
||
| if (process.env.NODE_ENV === 'test') { |
Member
There was a problem hiding this comment.
What do you think of this change instead:
-const { dangerouslyUseGlobalCSS = false, productionPrefix = 'jss', seed = '' } = options;
+const { dangerouslyUseGlobalCSS = process.env.NODE_ENV === 'test', productionPrefix = 'jss', seed = '' } = options;
oliviertassinari
changed the title
oliviertassinari
added
test
scope: styles
2 tasks
Member
|
I'm closing, for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14357