[Tabs] Add variant prop and deprecate fullWidth and scrollable props#13980
Conversation
|
@rfbotto I think the preferred route of deprecation, is to first display warnings when the deprecated prop is used and then in the next major version (v4) to remove them. |
|
That's a good point @joshwooding, didn't think of it. Then it should be fine to keep this PR open and only merge it into the next major version and in the meantime create a PR with the deprecation warning for those props (in case the solution in this PR gets accepted). |
b2d2fad to
075fe49
Compare
|
The deprecation path looks great, well done 👌 ! |
|
Nice. But I have some problem with this latest update. My tab will use fullWidth in mobile and using default in Desktop. Before this. It's very easy. const {classes, fullScreen} = this.props
<Tabs fullWidth={fullScreen}
...
export default withStyles(styles)(withMobileDialog()(Module))This latest update make my code become messy because variant props only accept 2 string.. Perhaps having a default value to set back to tabs behavior to default behavior is appreciated. 😺 |
|
Hi, I have to disagree with this change. |
Closes #13610
Deprecation
The Tabs
fullWidthandscrollableproperties can't be used at the same time. The API change prevents any awkward usage.