[FormControl] Use stable context API#13590
Merged
oliviertassinari merged 5 commits intoNov 14, 2018
Merged
Conversation
- fix ts not picking up type of context - normalize dom node assertion in this PR
oliviertassinari
force-pushed
the
fix/core/FormControl/stable-context
branch
from
November 14, 2018 21:56
35a15ec to
e8aa676
Compare
Member
|
@eps1lon Awesome job! While I hate the fact it's increasing the n° of underlying components we use for a single input, I'm confident that we will be able to drastically improve that in v4 with the usage of the React hooks 💯. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
withFormControlContextHOC to be able to access context via props without major component rewritedisableUnderlinewas spread to nativedivinInputBase)Only the styling solution remains with the deprecated context API.
Closes #13465.