[docs] Fix demo links for new util components#10337
Merged
Merged
Conversation
jprince
force-pushed
the
fix-util-demo-links
branch
from
February 17, 2018 19:26
1783795 to
7d0e0aa
Compare
Member
|
I'm looking into it. |
Author
|
@oliviertassinari oh ok. The build tipped me off that I shouldn't have modified the .md files directly, so I was closing while revisiting the approach. But 👍if you're on it. Thanks! |
oliviertassinari
added
type: bug
oliviertassinari
changed the title
Member
|
@jprince It's already fixed in #10288, but @oliviertassinari is going to generalize the approach. |
Member
|
Alright, I have found an elegant solution: consistency with the folder structure 👌. |
oliviertassinari
force-pushed
the
fix-util-demo-links
branch
from
February 18, 2018 10:18
7d0e0aa to
696c604
Compare
| } | ||
| let pathname = itemPath.replace(new RegExp(`\\${path.sep}`, 'g'), '/').replace(/^.*\/pages/, '').replace('.md', ''); | ||
|
|
||
| if (pathname.indexOf('/demos') === 0) { |
Member
There was a problem hiding this comment.
The code branch is no longer needed.
oliviertassinari
force-pushed
the
fix-util-demo-links
branch
from
February 18, 2018 11:23
696c604 to
6b74216
Compare
| # This isn't user facing code. | ||
| # Let's take advantage of the most up to date node version. | ||
| docker: | ||
| - image: circleci/node:9.4 |
This was referenced Feb 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ed76e11, released in v1.0.0-beta.34, several components were moved into the utils section. When making that change, a few links from component API docs to their demos were broken.