[Form] Create new Form component#589
Merged
Merged
Conversation
Netlify deploy preview |
atomiks
commented
Sep 10, 2024
| return ( | ||
| <form onSubmit={handleSubmit} noValidate> | ||
| <FieldRoot invalid={error}> | ||
| <FieldRoot invalid={error} name="email"> |
Contributor
Author
There was a problem hiding this comment.
name and diasbled were moved back onto <Field.Root> for SSR/layout shift reasons with the server-side errors prop and style hooks.
We should always try to avoid using effects to sync up data for this reason, unless it's a popup element (which requires interaction to appear for the most part, or at least until hydration which won't cause layout shift).
atomiks
commented
Sep 10, 2024
Comment on lines
+31
to
+40
| /** | ||
| * Whether the field is disabled. Takes precedence over the `disabled` prop of the `Field.Control` | ||
| * component. | ||
| * @default false | ||
| */ | ||
| disabled?: boolean; | ||
| /** | ||
| * The field's name. Takes precedence over the `name` prop of the `Field.Control` component. | ||
| */ | ||
| name?: string; |
Contributor
Author
There was a problem hiding this comment.
@michaldudak to avoid changing unrelated components too much, we can do namespace types refactoring in a new PR
michaldudak
reviewed
Sep 10, 2024
Co-authored-by: Michał Dudak <[email protected]> Signed-off-by: atomiks <[email protected]>
michaldudak
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #219