[menu] Group and Separator components#535
Merged
Merged
Conversation
michaldudak
added
component: menu
Netlify deploy preview |
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
removed
the
PR: out-of-date
michaldudak
marked this pull request as ready for review
September 6, 2024 13:26
atomiks
reviewed
Sep 18, 2024
atomiks
reviewed
Sep 18, 2024
atomiks
reviewed
Sep 18, 2024
Comment on lines
+18
to
+21
| const MenuGroup = React.forwardRef(function MenuGroup( | ||
| props: MenuGroup.Props, | ||
| forwardedRef: React.ForwardedRef<Element>, | ||
| ) { |
Contributor
There was a problem hiding this comment.
Can Menu groups have labels?
Member
Author
There was a problem hiding this comment.
Added MenuGroupLabel component.
Co-authored-by: atomiks <[email protected]> Signed-off-by: Michał Dudak <[email protected]>
github-actions
Bot
added
the
PR: out-of-date
github-actions
Bot
removed
the
PR: out-of-date
2 tasks
atomiks
approved these changes
Sep 24, 2024
Contributor
|
@michaldudak Label needs to be added to the Anatomy section code. |
colmtuite
approved these changes
Sep 27, 2024
Member
Author
|
Done. |
2 tasks
oliviertassinari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created the Group and Separator components for the Menu.
Closes #70