Skip to content

[menu] Overhaul the component API#468

Merged
michaldudak merged 122 commits into
mui:masterfrom
michaldudak:menu
Aug 2, 2024
Merged

[menu] Overhaul the component API#468
michaldudak merged 122 commits into
mui:masterfrom
michaldudak:menu

Conversation

@michaldudak

@michaldudak michaldudak commented Jun 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

michaldudak added 30 commits June 5, 2024 15:57
@michaldudak
Move related components under Menu
6ca6e15
@michaldudak
Rename Menu components and types
dc71a04
@michaldudak
useMenuRoot
98145a4
@michaldudak
Move hooks under components
ee3951c
@michaldudak
Docs page
3ff79ae
@michaldudak
Render props
d5dea02
@michaldudak
Fix types in tests
52b7c25
@michaldudak
Create a simple Positioner
2bbe4b3
@michaldudak
Overhaul menu reducers WIP
3f1e617
@michaldudak
Merge remote-tracking branch 'upstream/master' into menu-on-hooks
dde423d
@michaldudak
Refactor listReducer
6f16604
@michaldudak
Remove unnecessary ListReducerAction type
588fab3
@michaldudak
Refactor useList
3a897d1
@michaldudak
Clean up useControllableReducer
adf7da1
@michaldudak
Make useList tests pass
c59b3d4
@michaldudak
Use new conformance tests
a04e0d0
@michaldudak
Move menuReducer logic to dropdownReducer
8f54897
@michaldudak
Few renames
c4b4b40
@michaldudak
Refactor MenuRoot and MenuPopup
8fedc16
@michaldudak
Create MenuPopupContext
fc12227
@michaldudak
Refactor useMenuItem
e6db65a
@michaldudak
Improve prop merging
74b190b
@michaldudak
Fixes
0967e20
@michaldudak
Merge remote-tracking branch 'upstream/master' into menu-on-hooks
5dce37b
@michaldudak
Fix tests
f828cff
@michaldudak
More tests
c07a159
@michaldudak
Refactor Tabs to use new patterns
88a5740
@michaldudak
Cleanup
d6086ac
@michaldudak
Remove value from list item metadata
e607ee6
@michaldudak
Fix tabs
67d0f19
@atomiks

atomiks commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

Bug when traversing back to the submenu trigger, menu doesn't open

Screen.Recording.2024-07-25.at.11.33.36.PM.mov

@colmtuite

colmtuite commented Jul 25, 2024

Copy link
Copy Markdown
Contributor

@michaldudak Feedback based on our chat:

  1. Add the Arrow component
  2. Consider making focus looping configurable. I vote it should be.
  3. Rename positionStrategy to positionMethod across all components.

@michaldudak

michaldudak commented Jul 26, 2024

Copy link
Copy Markdown
Member Author

@colmtuite I did 1 and 2. positionStrategy rename should be done on the other components first in a separate PR.

@colmtuite

colmtuite commented Jul 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

@michaldudak In this vid, the menu is initially opening above the trigger, then quickly repositioning itself below.
https://github.com/user-attachments/assets/dee98c5c-a19b-47ab-8f8b-2c2f07b0eb30

@michaldudak

michaldudak commented Jul 26, 2024

Copy link
Copy Markdown
Member Author

Bug when traversing back to the submenu trigger, menu doesn't open

@atomiks, Should be working OK now.

In this vid, the menu is initially opening above the trigger, then quickly repositioning itself below.

@colmtuite, could you prepare a reproduction on codesandbox?

oliviertassinari
oliviertassinari reviewed Jul 26, 2024
View reviewed changes
Comment thread packages/mui-base/src/Menu/Positioner/MenuPositionerContext.ts Outdated
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 1, 2024
@colmtuite
colmtuite self-requested a review August 1, 2024 11:43
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Aug 1, 2024
@michaldudak michaldudak mentioned this pull request Aug 2, 2024
Closed
14 tasks
atomiks
atomiks approved these changes Aug 2, 2024
View reviewed changes

@atomiks atomiks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@michaldudak
michaldudak merged commit a71c099 into mui:master Aug 2, 2024
@michaldudak
michaldudak deleted the menu branch August 2, 2024 11:54
@sai6855 sai6855 mentioned this pull request Aug 3, 2024
Merged
1 task
@oliviertassinari oliviertassinari changed the title [Menu] Overhaul the component API [menu] Overhaul the component API May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments
@colmtuite colmtuite colmtuite approved these changes
@atomiks atomiks atomiks approved these changes

Assignees

No one assigned

Labels

breaking change Introduces changes that are not backward compatible. component: menu Changes related to the menu component.

Projects

None yet

Milestone

No milestone

6 participants

@michaldudak @mui-bot @colmtuite @DiegoAndai @atomiks @oliviertassinari