Repository navigation
fix(pocket-tts): honour the language option when loading the model - #12766
Merged
Merged
Conversation
Pocket TTS ships one model per language, but LoadModel called TTSModel.load_model() with no arguments, so the library always fell back to its English model whatever the model config said. Read a `language` option and pass it to load_model, keeping the library default when it is not set. Document the option and add unit tests that mock the loader. Fixes mudler#12759 Assisted-by: Claude:claude-opus-5-5
drakeo338
marked this pull request as ready for review
October 19, 2026 03:09
mudler
approved these changes
Oct 19, 2026
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #12759
Pocket TTS ships a separate model for each language, but the backend called
TTSModel.load_model()with no arguments. The library then loads English, so no model option or voice could switch it.LoadModelnow reads alanguageoption (options: ["language:french"]) and passes it toload_model(language=...). Without the option the call is unchanged and the library default still applies. Thelanguageargument has been inpocket-ttssince 2.0.0, and the requirements are unpinned. Built-in voice names resolve against the loaded language model, and every voice has an embedding for each language upstream.Notes for Reviewers
test.pygets aTestLanguageOptionclass that mocksTTSModel.load_model, so it downloads no weights. Two of its three cases fail without the fix. I documented the option intext-to-audio.mdand added a commented example togallery/pocket-tts.yaml.I wrote this with help from Claude and reviewed and tested every change myself.
Signed commits