Repository navigation
Commit f4a6137
authored
fix(kubernetes): keep a late stop snapshot from reviving a stopped sandbox (NVIDIA#5196)
* fix(kubernetes): keep a late stop snapshot from reviving a stopped sandbox
A stop keeps the sandbox-runtime bootstrap annotations, with operation
"stop", until its completion patch. The watch converter marked every
object with those annotations as a starting generation: it added
Bootstrapping=True and dropped Suspended. The gateway treats that
condition as an accepted start that may replace a settled Stopped
phase, so a snapshot taken mid-stop and delivered after the stop
settled moved the sandbox from Stopped to Provisioning and the next
stop was rejected.
For operation "stop", withdraw readiness and withhold the suspension
until completion as before, but do not report Bootstrapping. Create
and restart keep their existing marking, so a real start still
recovers a stale Stopped view.
Closes NVIDIA#5195
Signed-off-by: Matthew Grossman <[email protected]>
* test(kubernetes): cover the full stop sequence for stop snapshots
Replace the late-stop gateway test with one that walks a stop from
Stopping through completion and then replays the in-flight snapshot, with
and without a connected supervisor session. An in-flight stop snapshot,
which now withdraws readiness without Bootstrapping or Suspended, keeps
the sandbox Stopping rather than Provisioning or Error; completion
settles it Stopped; and the late replay leaves it Stopped. The test
documents that it guards the gateway contract and that the driver test
covers the regression itself.
Share the condition reset between the stopping and bootstrapping
markers in the Kubernetes driver.
Refs NVIDIA#5195
Signed-off-by: Matthew Grossman <[email protected]>
---------
Signed-off-by: Matthew Grossman <[email protected]>1 parent fab1404 commit f4a6137
2 files changed
Lines changed: 192 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6923 | 6923 | | |
6924 | 6924 | | |
6925 | 6925 | | |
6926 | | - | |
6927 | 6926 | | |
6928 | 6927 | | |
6929 | 6928 | | |
6930 | 6929 | | |
6931 | 6930 | | |
6932 | 6931 | | |
6933 | | - | |
6934 | | - | |
6935 | | - | |
6936 | | - | |
| 6932 | + | |
6937 | 6933 | | |
6938 | 6934 | | |
6939 | 6935 | | |
| |||
6972 | 6968 | | |
6973 | 6969 | | |
6974 | 6970 | | |
| 6971 | + | |
| 6972 | + | |
| 6973 | + | |
| 6974 | + | |
| 6975 | + | |
| 6976 | + | |
| 6977 | + | |
| 6978 | + | |
| 6979 | + | |
| 6980 | + | |
| 6981 | + | |
| 6982 | + | |
| 6983 | + | |
| 6984 | + | |
| 6985 | + | |
| 6986 | + | |
| 6987 | + | |
| 6988 | + | |
| 6989 | + | |
| 6990 | + | |
| 6991 | + | |
| 6992 | + | |
| 6993 | + | |
| 6994 | + | |
6975 | 6995 | | |
| 6996 | + | |
6976 | 6997 | | |
6977 | | - | |
6978 | | - | |
6979 | | - | |
6980 | 6998 | | |
6981 | 6999 | | |
6982 | 7000 | | |
| |||
6988 | 7006 | | |
6989 | 7007 | | |
6990 | 7008 | | |
| 7009 | + | |
| 7010 | + | |
| 7011 | + | |
| 7012 | + | |
| 7013 | + | |
| 7014 | + | |
| 7015 | + | |
| 7016 | + | |
6991 | 7017 | | |
6992 | 7018 | | |
6993 | 7019 | | |
| |||
14451 | 14477 | | |
14452 | 14478 | | |
14453 | 14479 | | |
| 14480 | + | |
| 14481 | + | |
| 14482 | + | |
| 14483 | + | |
| 14484 | + | |
| 14485 | + | |
| 14486 | + | |
| 14487 | + | |
| 14488 | + | |
| 14489 | + | |
| 14490 | + | |
| 14491 | + | |
| 14492 | + | |
| 14493 | + | |
| 14494 | + | |
| 14495 | + | |
| 14496 | + | |
| 14497 | + | |
| 14498 | + | |
| 14499 | + | |
| 14500 | + | |
| 14501 | + | |
| 14502 | + | |
| 14503 | + | |
| 14504 | + | |
| 14505 | + | |
| 14506 | + | |
| 14507 | + | |
| 14508 | + | |
| 14509 | + | |
| 14510 | + | |
| 14511 | + | |
| 14512 | + | |
| 14513 | + | |
| 14514 | + | |
| 14515 | + | |
| 14516 | + | |
| 14517 | + | |
| 14518 | + | |
| 14519 | + | |
| 14520 | + | |
| 14521 | + | |
| 14522 | + | |
| 14523 | + | |
| 14524 | + | |
| 14525 | + | |
| 14526 | + | |
| 14527 | + | |
| 14528 | + | |
| 14529 | + | |
| 14530 | + | |
| 14531 | + | |
| 14532 | + | |
| 14533 | + | |
| 14534 | + | |
| 14535 | + | |
| 14536 | + | |
| 14537 | + | |
| 14538 | + | |
| 14539 | + | |
| 14540 | + | |
| 14541 | + | |
| 14542 | + | |
| 14543 | + | |
| 14544 | + | |
| 14545 | + | |
| 14546 | + | |
| 14547 | + | |
| 14548 | + | |
| 14549 | + | |
| 14550 | + | |
| 14551 | + | |
| 14552 | + | |
| 14553 | + | |
| 14554 | + | |
| 14555 | + | |
| 14556 | + | |
| 14557 | + | |
| 14558 | + | |
| 14559 | + | |
| 14560 | + | |
| 14561 | + | |
| 14562 | + | |
| 14563 | + | |
| 14564 | + | |
| 14565 | + | |
| 14566 | + | |
| 14567 | + | |
| 14568 | + | |
| 14569 | + | |
| 14570 | + | |
| 14571 | + | |
| 14572 | + | |
| 14573 | + | |
| 14574 | + | |
| 14575 | + | |
| 14576 | + | |
| 14577 | + | |
14454 | 14578 | | |
14455 | 14579 | | |
14456 | 14580 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14327 | 14327 | | |
14328 | 14328 | | |
14329 | 14329 | | |
| 14330 | + | |
| 14331 | + | |
| 14332 | + | |
| 14333 | + | |
| 14334 | + | |
| 14335 | + | |
| 14336 | + | |
| 14337 | + | |
| 14338 | + | |
| 14339 | + | |
| 14340 | + | |
| 14341 | + | |
| 14342 | + | |
| 14343 | + | |
| 14344 | + | |
| 14345 | + | |
| 14346 | + | |
| 14347 | + | |
| 14348 | + | |
| 14349 | + | |
| 14350 | + | |
| 14351 | + | |
| 14352 | + | |
| 14353 | + | |
| 14354 | + | |
| 14355 | + | |
| 14356 | + | |
| 14357 | + | |
| 14358 | + | |
| 14359 | + | |
| 14360 | + | |
| 14361 | + | |
| 14362 | + | |
| 14363 | + | |
| 14364 | + | |
| 14365 | + | |
| 14366 | + | |
| 14367 | + | |
| 14368 | + | |
| 14369 | + | |
| 14370 | + | |
| 14371 | + | |
| 14372 | + | |
| 14373 | + | |
| 14374 | + | |
| 14375 | + | |
| 14376 | + | |
| 14377 | + | |
| 14378 | + | |
| 14379 | + | |
| 14380 | + | |
| 14381 | + | |
| 14382 | + | |
| 14383 | + | |
| 14384 | + | |
| 14385 | + | |
| 14386 | + | |
| 14387 | + | |
| 14388 | + | |
| 14389 | + | |
14330 | 14390 | | |
14331 | 14391 | | |
14332 | 14392 | | |
| |||
0 commit comments