Skip to content

Fix overflow when using large raster sizes#13

Merged
mthh merged 7 commits intomthh:masterfrom
SenseLabsDE:fix-overflow
Apr 15, 2024
Merged

Fix overflow when using large raster sizes#13
mthh merged 7 commits intomthh:masterfrom
SenseLabsDE:fix-overflow

Conversation

@netthier
Copy link
Copy Markdown
Contributor

@netthier netthier commented Apr 12, 2024

This fixes #12.
It contains breaking changes, as some u32s in public function signatures have been swapped with usizes, requiring an appropriate version bump.

netthier and others added 6 commits April 11, 2024 18:05
@netthier
Increase variable width in isoringbuilder.rs and contourbuilder.rs to…
17053d2 
… support larger inputs

Signed-off-by: netthier <[email protected]>
@netthier
Eliminate obsolete casts
daad8a1 
Signed-off-by: netthier <[email protected]>
@netthier
Fix example dataset size types
c652ab8 
Signed-off-by: netthier <[email protected]>
@netthier
Fix benchmark dataset size types
60a8d77 
Signed-off-by: netthier <[email protected]>
@netthier @mthh
Fix index calculation in index
b32d16b 
Signed-off-by: netthier <[email protected]>
Co-authored-by: Matthieu Viry <[email protected]>
@netthier
Run cargo fmt
96db165 
Signed-off-by: netthier <[email protected]>
@netthier
Copy link
Copy Markdown
Contributor Author

netthier commented Apr 12, 2024 •
edited
Loading

Huh, what's that failure on nightly there? Seems like f32 literals are broken?

UPDATE: I think we're hitting rust-lang/rust#123824, it should be fine to ignore? Though maybe explicitly specifying a type would make sense here, this doesn't seem well-defined. Let me know if you want me to add that to this PR or not.

@netthier netthier marked this pull request as draft April 12, 2024 13:20
@netthier
Copy link
Copy Markdown
Contributor Author

netthier commented Apr 12, 2024

Do not merge this, it seems like there is another precision issue. I'll post more details in the issue

@mthh
Copy link
Copy Markdown
Owner

mthh commented Apr 12, 2024

I think we're hitting rust-lang/rust#123824 [...] Let me know if you want me to add that to this PR or not.

Yeah I think so. The PR fixing the issue you reference seems to be in the merge queue so no need to worry about that, I think.

it seems like there is another precision issue. I'll post more details in the issue

Alright :-/

@mthh mthh mentioned this pull request Apr 12, 2024
Closed
@tgross35 tgross35 mentioned this pull request Apr 12, 2024
Closed
@netthier @mthh
Always use f64 for area calculation
3dc78d4 
Signed-off-by: netthier <[email protected]>
Co-Authored-by: Matthieu Viry <[email protected]>
@netthier netthier marked this pull request as ready for review April 15, 2024 10:45
@netthier netthier mentioned this pull request Apr 15, 2024
Draft
@mthh
Copy link
Copy Markdown
Owner

mthh commented Apr 15, 2024

Great, thanks for your contribution. I will merge this now (and make a new release later today) because it brings improvements and corrections that are already useful.
And we'll continue the discussion on #14.

@mthh mthh merged commit 2e58cfb into mthh:master Apr 15, 2024
@netthier netthier deleted the fix-overflow branch April 15, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Overflow/Artifacts with large rasters (>40k*40k)

2 participants

@netthier @mthh