forked from rstudio/bookdown
-
Notifications
You must be signed in to change notification settings - Fork 0
Updates/from upstream #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…side RStudio Viewer; also close rstudio#691 accordingly the fix cbe9f10 for rstudio#165 was incomplete: it didn't consider the case outside RStudio Viewer, hence the content loses focus when a page is loaded in a normal web browser
… the clumsy bounding rectangle method to scroll the keyword into view
…bout the keybindings
…d the tooltip of the search input
Revert the hackish solution "associate localStorage with the book title, i.e. when the book title has changed, clear local storage (e.g. search terms, scroll positions, etc)" This reverts commit a41b535.
…r, also find the visible items in TOC
…ok pages now, e.g., if you have reached the last match on the current page, pressing Down or Enter will bring you to the next page that contains the match
…ing hashes; in other words, only display items that point to top-level .html files, so that users know these are the only possible targets that they need to look at
… used in the search keyword
… = TRUE), otherwise we'll get a warning about R expressions in YAML same issue as rstudio/rmarkdown#1387
…mment with #bookdown:version#
…hapter title (I don't know how rstudio#688 could possibly happen, though)
… when format is NULL, I shouldn't call files2[[format]]; format will be NULL if the output format is not HTML or LaTeX, in which case I'll just use the default list of Rmd input files
…ill get a new figure/table number)
…tions and an h2 follows immediately an h1 (rstudio#849)
…efore_chapter_script and after_chapter_scripts separately, instead of writing them into the Rmd files as code chunks
… \begin and \end, respectively
…ok for it at the end of a line instead
…bdir are provided (rstudio#886)
…nd input files from subdirectories
…d of respecting its original order, which led to the bug
… we should also mention biblatex (rstudio#772)
…out the code `file.exists(main) && is.null(delete_main)`
…racter string to the chapter_name function also close rstudio/bookdown-demo#55
Co-authored-by: Yihui Xie <[email protected]>
…ream Conflicts: DESCRIPTION
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.