This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Kb/msys/unicode console input #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karsten Blees <[email protected]>
…tions Add support for Unicode console input and backport multibyte / wide char conversion functions from newlib 1.20 (needed by bash for Unicode-aware line editing). Signed-off-by: Karsten Blees <[email protected]>
Copy newlib header files to the msys include directory, update msys.dll import library. Signed-off-by: Karsten Blees <[email protected]>
Signed-off-by: Karsten Blees <[email protected]>
Enable multibyte support in the bash release script and fix a small compile error in the bash multibyte code. Signed-off-by: Karsten Blees <[email protected]>
Signed-off-by: Karsten Blees <[email protected]>
Enable multibyte character on input and output and disable ASCII conversion in etc/inputrc. Signed-off-by: Karsten Blees <[email protected]>
Contributor
Author
|
Sorry I forgot to clarify the 'most' in 'most users'. The console input code in fhandler_console::read currently doesn't decode UTF-16 surrogate pairs (> \u0ffff, e.g. CJK extensions). I couldn't find any hint on how ReadConsoleInputW transmits these (not even in cygwin's fhandler_console), and as I have no way to test this either, I'd like to leave this one to CJK users who actually have that problem. |
|
Want! |
Contributor
|
@stevenkling So if you want this, you could help by
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches should fix the Unicode line editing issues in msys bash for most users (see http://groups.google.com/group/msysgit/browse_thread/thread/f365e1c841beef62 ).
The major part of the patch series was backporting the multibyte to wide char conversion functions from newlib 1.20 / cygwin 1.7 to the current msys.dll (based on newlib 1.9), so that bash could be compiled with multibyte support.
I'll send another pull request for the devel branch (binaries only).
Cheers,
Karsten