Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@t-b
Copy link
Contributor

@t-b t-b commented Sep 29, 2014

I just felt like updating bash. Not because some heavy security bugs have been found ;)

As already stated in the info mail on the msysgit mailing list, I've included, against our rules, some binary files to compile bash.
But as msysgit is basically EOL, I hope this is okay.

Once this is merged I'll cherry-pick 895e4dd to msysgit/master on my own. Okay?

@t-b
Copy link
Contributor Author

t-b commented Sep 29, 2014

Btw. I expect that more bash bugs will surface in the next days/weeks. So I'll guess I'll have to do a new release quite soon again.

@t-b
Copy link
Contributor Author

t-b commented Sep 29, 2014

Except the usual and minor svn test breakages, all other git tests pass with the new bash.

@dscho
Copy link
Member

dscho commented Sep 29, 2014

@t-b if you feel that we need to release a new Bash, sure, let's go with your PR. You spent waaaay more time than I would have to fix something I had the impression only affects setups running servers (and Git for Windows does not really do that). So you definitely deserve a reward! ;-)

dscho added a commit that referenced this pull request Sep 29, 2014
Update bash to patch release 20
@dscho dscho merged commit 26713cc into msysgit:msys Sep 29, 2014
@t-b
Copy link
Contributor Author

t-b commented Sep 29, 2014

@dscho Well it was also a good occasion to get the other bash fixes. Thanks for merging.

@niik
Copy link

niik commented Oct 1, 2014

@t-b Me and the rest of the GitHub for Windows team are most grateful for your work on this ✨ Can I hook you up with some stickers as a small way of saying thanks?

@t-b t-b deleted the tb_add_newer_bash branch October 1, 2014 20:43
@t-b
Copy link
Contributor Author

t-b commented Oct 1, 2014

@niik Thanks! I'd love to have some stickers. You should have my email if you read git or msysgit mailing list, no? I don't like posting my post address here ;)

@niik
Copy link

niik commented Oct 1, 2014

@t-b Awesome, just send me your postal address to my email and I'll send some. My address is my username at the very domain you're reading this on!

@t-b
Copy link
Contributor Author

t-b commented Oct 1, 2014

@niik Sent!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants