Apart from the binaries and the extra COPYING files to be patched in, this looks really good! I would probably untangle the configure.ac from the configure patches so that it is easier to upgrade, but I guess that could be done when upgrading.

I could make a shell script instead of adding *.dll.a binaries. And I'm ok to remove COPYING.

I could make a shell script instead of adding *.dll.a binaries.

Well, I was really curious from where you got them...

I fixed the following points.

• remove binaries and openssh release.sh creates *.dll.a binaries
• remove COPYING file in the crypt patch
• use autoreconf instead of configure patch in openssh

Thank you!

Just one more question: you extracted the headers for msys-crypto-0.9.8.dll and msys-minires.dll from where? I just went for a hunt for five minutes (using up a third of my daily Git time budget) and could not find any sensible candidate. Would be nice if you could mention the source for those files in the commit message (also to confirm that the headers match the existing binaries).

After that, we'll be good to go! Thank you so much for all your hard work!

I used the following files. Updated the commit messages.

http://sourceforge.net/projects/mingw/files/OldFiles/msys-openssl/openssl-0.9.8e-3-MSYS-1.0.11.tar.bz2/download
http://sourceforge.net/projects/mingw/files/OldFiles/msys-minires/minires-1.01-1-MSYS-1.0.11.tar.bz2/download

OpenSSH configure has the check that the openssl headers match the existing binary (0.9.8e).
msys-minires.dll was added to the repository at year 2008. At the time latest minires version is 1.01.

I succeed to build OpenSSH 6.6p1 for msys. Added the commit.
Can we use OpenSSH 6.6p1?

Excellent work, @shirosaki! @kusma thank you for your review! I will now let my slow VM build it... ;-)

@shirosaki I also found that I had to remove some obsolete headers... Did you have to do something similar to 7cf3e99?

I cherry-picked the compiled OpenSSH binaries and put it on the branch ssh-6.6p1 so I can test it thoroughly first.

Tested and merged. Thank you again!

Thank you for merging and test.
I didn't notice obsolete headers. My build completed without removing the headers.

It seems msys-crypt is not needed for OpenSSH 6.6p1.
crypt would be replaced with DES_crypt in openssl if crypt is not available.

openbsd-compat/xcrypt.c:62

#  define crypt DES_crypt

https://github.com/msysgit/msysgit/blob/msys/bin/slogin looks obsolete.
It should be removed since slogin.exe exists.

I didn't notice obsolete headers. My build completed without removing the headers.

Okay, strange. Maybe some timestamp issue where my checkout let other directories in the INCLUDE search path take precedence.

It seems msys-crypt is not needed for OpenSSH 6.6p1.

Thanks for the analysis! However, in the interest of time I am inclined to leave things as they are. If you feel strongly about this issue, though, just file a PR and I will merge it right away!

https://github.com/msysgit/msysgit/blob/msys/bin/slogin looks obsolete.
It should be removed since slogin.exe exists.

Thanks! See 4f2618e