Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@snaewe
Copy link
Contributor

@snaewe snaewe commented Feb 21, 2014

As requested by @sschuberth in #169 I changed all src/\<package\>/release.sh to
use commit -n.
While doing that I noticed that some packages cannot be built (e.g. zlib-1.2.7.tar.gz doesn't exist).
If I find some time I'll try to fix some of them....later.

This PR is on top of my sn/vim74. If that's not OK, just tell me.

@sschuberth
Copy link
Contributor

Actually you should make the commit that adds -n to all scripts the first one, and also add -n for vim in that commit. During the interactive rebase Git will then just skip the addition of -n as part of the following "update vim to 7.4" commit.

@sschuberth sschuberth mentioned this pull request Feb 21, 2014
@snaewe
Copy link
Contributor Author

snaewe commented Feb 21, 2014

Will do.

Makes it possible to commit inside of /src/<package>/release.sh when
core.whitespace is set and an auto-enabled pre-commit hook
(i.e. init.templatedir is set) is used that checks for whitespace problems.

Signed-off-by: Stefan Naewe <[email protected]>
Signed-off-by: Stefan Naewe <[email protected]>
Signed-off-by: Stefan Naewe <[email protected]>
dscho added a commit that referenced this pull request Feb 23, 2014
This pull request fixes all /src/ release.sh scripts to disregard
certain settings which would interfere with them otherwise.

It also updates our vim to version 7.4.

Thanks, Stefan Naewe!

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho merged commit 686da0b into msysgit:master Feb 23, 2014
@dscho
Copy link
Member

dscho commented Feb 23, 2014

Thanks!

@dscho
Copy link
Member

dscho commented Feb 23, 2014

Oh, and in case you missed it, @snaewe, I updated to zlib 1.2.8 in response to your notice.

@snaewe snaewe deleted the sn/commit-dash-n branch February 24, 2014 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants