Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@n8felton
Copy link
Contributor

Resolves #165

@dscho
Copy link
Member

dscho commented Feb 18, 2014

@n8felton oh, sorry! If I had known it'd be that quick, I would have held off... @sschuberth could you have a look when you have time?

@sschuberth
Copy link
Contributor

I really don't have time for a thorough review currently. Just from a very quick glance I see a lot of indentation and style issues. I'd prefer to not merge this as-is.

@n8felton
Copy link
Contributor Author

b518955 has the proper whitespaces; I converted the TABs to Spaces. Sorry about that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the whitespace after , and : to match the existing style.

@sschuberth
Copy link
Contributor

Thanks for the update. I've commented on a few lines that still have style issues, but there are more lines. In general, our currently style does not use whitespaces before / after special characters.

@n8felton
Copy link
Contributor Author

I see more what you mean now by style. I'll make these changes and resubmit.

@n8felton
Copy link
Contributor Author

Alright, give d30295f a look and let me know what you think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still spaces here next to <> ;-) Similar in other places below.

@sschuberth
Copy link
Contributor

Besides all my style comments, I assume that you have actually build the installer and verified that it works as expected, correct?

@n8felton
Copy link
Contributor Author

Yes, after each style correction suggestion, I am running the release.sh script to build the installer and I am testing the functionality.

@dscho
Copy link
Member

dscho commented Feb 18, 2014

@n8felton oh, I thought you had tested it already. For my curiosity, could you paste a .inf file in a comment to this ticket (I'd like to see how it looks like to get a feel what one can do with it)?

@n8felton
Copy link
Contributor Author

Example INF after running a /saveinf argument with my preferred settings.

[Setup]
Lang=default
Dir=C:\Program Files (x86)\Git
Group=Git
NoIcons=0
SetupType=default
Components=assoc,assoc_sh
Tasks=
PathOption=BashOnly
SSHOption=OpenSSH
CRLFOption=CRLFCommitAsIs

@n8felton
Copy link
Contributor Author

Check out f5f991e. Hopefully I have all (if not most) of the style errors fixed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit-pick, please add a blank line after this one, as these are global variables and do not belong to UpdateInfFilenames.

@n8felton
Copy link
Contributor Author

b53b404 is up. Let me know what you think.

@sschuberth
Copy link
Contributor

Looks good to me now. @dscho Please merge it you're OK with it, too.

dscho added a commit that referenced this pull request Feb 18, 2014
Allow for custom settings to be saved to the INF file set by /SAVEINF
@dscho dscho merged commit 6396cb1 into msysgit:master Feb 18, 2014
@dscho
Copy link
Member

dscho commented Feb 18, 2014

Thanks both!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow line ending conversions to be set in Inno Setup INF file

3 participants