-
Notifications
You must be signed in to change notification settings - Fork 588
Allow for custom settings to be saved to the INF file set by /SAVEINF #168
Conversation
|
@n8felton oh, sorry! If I had known it'd be that quick, I would have held off... @sschuberth could you have a look when you have time? |
|
I really don't have time for a thorough review currently. Just from a very quick glance I see a lot of indentation and style issues. I'd prefer to not merge this as-is. |
|
b518955 has the proper whitespaces; I converted the TABs to Spaces. Sorry about that. |
share/WinGit/helpers.inc.iss
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the whitespace after , and : to match the existing style.
|
Thanks for the update. I've commented on a few lines that still have style issues, but there are more lines. In general, our currently style does not use whitespaces before / after special characters. |
|
I see more what you mean now by style. I'll make these changes and resubmit. |
|
Alright, give d30295f a look and let me know what you think. |
share/WinGit/helpers.inc.iss
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still spaces here next to <> ;-) Similar in other places below.
|
Besides all my style comments, I assume that you have actually build the installer and verified that it works as expected, correct? |
|
Yes, after each style correction suggestion, I am running the release.sh script to build the installer and I am testing the functionality. |
|
@n8felton oh, I thought you had tested it already. For my curiosity, could you paste a |
|
Example INF after running a /saveinf argument with my preferred settings. [Setup] |
|
Check out f5f991e. Hopefully I have all (if not most) of the style errors fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit-pick, please add a blank line after this one, as these are global variables and do not belong to UpdateInfFilenames.
…EINF argument. Resolves msysgit#165
|
b53b404 is up. Let me know what you think. |
|
Looks good to me now. @dscho Please merge it you're OK with it, too. |
Allow for custom settings to be saved to the INF file set by /SAVEINF
|
Thanks both! |
Resolves #165