Skip to content
This repository was archived by the owner on Nov 9, 2017. It is now read-only.

Conversation

@n8felton
Copy link
Contributor

No description provided.

@dscho
Copy link
Member

dscho commented Feb 17, 2014

Hmm. What is the rationale? What does this fix?

@n8felton
Copy link
Contributor Author

No real rationale, just while looking into #165, I noticed that the InnoSetup was outdated. Was just updating to 5.5.4 to ensure that while I was testing solutions for #165 that there were not any issues that might have been resolved in the latest version of InnoSetup.

@sschuberth
Copy link
Contributor

Looks good to me, I just did not update to this Inno Setup version because there we no changes that we would immediately benefit from.

sschuberth added a commit that referenced this pull request Feb 17, 2014
Installer: Update Inno Setup to version 5.5.4 (Unicode)
@sschuberth sschuberth merged commit cff197b into msysgit:master Feb 17, 2014
@dscho
Copy link
Member

dscho commented Feb 17, 2014

@n8felton do you want me to hold off with a new release until you make a pull request for the /LOADINF support? I could wait up to a day, I guess...

@n8felton n8felton deleted the innosetup5.5.4 branch February 17, 2014 21:05
@n8felton
Copy link
Contributor Author

@dscho No, go ahead and release, there is very limited documentation on the loadinf/saveinf feature and i'm not exactly a pro at INNO scripts, so it'll take me some time to get it to work and not break anything in the process.

@dscho
Copy link
Member

dscho commented Feb 17, 2014

@n8felton okay... once your done, we can easily release another Git 1.9.0 preview <date>.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants