This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Fix menu commands blocking the file manager process #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f743394. Most Git-Cheetah commands are expected to launch an independent process, without blocking the calling file manager application. Signed-off-by: Karsten Blees <[email protected]>
Git-Cheetah redirects and reads stdout / stderr of forked commands only if it needs to. Otherwise this output simply goes to stdout / stderr of the calling file manager process. This is OK for GUI-based file managers (e.g. Windows Explorer), as there is no console. For text-based file managers (e.g. Far Manager) this is a problem, as such unwanted console output messes up the UI. Redirect stdout / stderr of forked commands to /dev/null if Git-Cheetah doesn't need it. Signed-off-by: Karsten Blees <[email protected]>
Member
Member
|
Okay, since nobody chimed in who has a chance to test FarManager I am willing to force them to test by merging this. |
dscho
added a commit
that referenced
this pull request
Mar 14, 2014
Fix menu commands blocking the file manager process
This was referenced Mar 21, 2014
Member
|
Unfortunately, the FarManager users were not bitten, but the Windows Explorer crowd. Hopefully #15 addresses this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of PR #11, Git-Cheetah menu commands that were supposed to launch a separate process (such as "Git Bash", "Git GUI") would block the file manager process until the child process exits.
This PR reverts PR #11 and adds an alternate solution to the "Git-Cheetah prints to the console" problem.