Don't change os.sep with an empty MSYSTEM env var, not just a missing one#107
Merged
lazka merged 2 commits intoSep 23, 2022
Merged
Conversation
… one Up until now this didn't really happen when calling from cygwin because empty env vars were removed before Python would run. But msys2/msys2-runtime#101 changed that. To avoid breaking users that did something like MSYSTEM= python ... not only check that MSYSTEM isn't set but also that it isn't empty when deciding if os.sep/os.altsep should be switched.
lazka
marked this pull request as ready for review
September 23, 2022 07:06
lazka
added a commit
to lazka/meson
that referenced
this pull request
Sep 23, 2022
…eparator behaviour" This reverts commit 3fd2459. The underlying issue has been fixed and deployed: msys2-contrib/cpython-mingw#107
xclaesse
pushed a commit
to mesonbuild/meson
that referenced
this pull request
Sep 23, 2022
…eparator behaviour" This reverts commit 3fd2459. The underlying issue has been fixed and deployed: msys2-contrib/cpython-mingw#107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up until now this didn't really happen when calling from cygwin
because empty env vars were removed before Python would run.
But msys2/msys2-runtime#101 changed that.
To avoid breaking users that did something like
MSYSTEM= python ...
not only check that MSYSTEM isn't set but also that it isn't empty
when deciding if os.sep/os.altsep should be switched.