Skip to content

fixup! Revert "Default to disable_pcon"#102

Merged
lazka merged 1 commit into
msys2:msys2-3_3_6-releasefrom
lazka:default-to-pcon
Sep 20, 2022
Merged

fixup! Revert "Default to disable_pcon"#102
lazka merged 1 commit into
msys2:msys2-3_3_6-releasefrom
lazka:default-to-pcon

Conversation

@lazka

@lazka lazka commented Sep 13, 2022

Copy link
Copy Markdown
Member

This reverts commit 8e89fff.

We want to try enabling it by default again, see #98

dscho
dscho approved these changes Sep 17, 2022
View reviewed changes

@dscho dscho left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just one suggestion: To make it easier to remember to drop the original commit during the next rebase, could you change the commit subject to:

fixup! Default to `disable_pcon`

?

@lazka
fixup! Revert "Default to disable_pcon"
183ee52 
This reverts commit 8e89fff.

We want to try enabling it by default again, see msys2#98
@lazka lazka changed the title Revert "Default to disable_pcon" fixup! Revert "Default to disable_pcon" Sep 20, 2022
@lazka lazka changed the title fixup! Revert "Default to disable_pcon" fixup! Revert "Default to disable_pcon" Sep 20, 2022
@lazka
lazka merged commit f5d3765 into msys2:msys2-3_3_6-release Sep 20, 2022
@lazka lazka mentioned this pull request Sep 20, 2022
Closed
@dscho

dscho commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

@lazka are you planning on opening a PR over at https://github.com/msys2/MSYS2-packages?

If not, I was planning on merging #101, and I could do a single MSYS2-packages PR for both.

@lazka

lazka commented Sep 20, 2022

Copy link
Copy Markdown
Member Author

I was. I'm happy to wait, but also don't mind multiple PRs..

@dscho

dscho commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

I'll go ahead and make a combined one (multiple PRs for MSYS2-packages/msys2-runtime won't work, they will conflict instead).

dscho added a commit to dscho/MSYS2-packages that referenced this pull request Sep 20, 2022
@dscho
msys2-runtime: enable pseudo consoles and empty values of env variables
3dad035 
This integrates the patches from
msys2/msys2-runtime#102 and from
msys2/msys2-runtime#101

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho mentioned this pull request Sep 20, 2022
Merged
@dscho

dscho commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

I'll go ahead and make a combined one (multiple PRs for MSYS2-packages/msys2-runtime won't work, they will conflict instead).

Here you go: msys2/MSYS2-packages#3195

I'll turn off draft mode once I see the CI build pass.

@dscho

dscho commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

I'll turn off draft mode once I see the CI build pass.

@lazka I marked msys2/MSYS2-packages#3195 as ready for review.

@git-for-windows-ci git-for-windows-ci mentioned this pull request Sep 21, 2022
Closed
@jeremyd2019 jeremyd2019 mentioned this pull request Jan 26, 2023
Closed
@Geoffrey-A

Geoffrey-A commented Jan 9, 2024

Copy link
Copy Markdown

This revert caused the issue #185.

github-actions Bot pushed a commit to cygapiss/msys2-apiss that referenced this pull request Jul 2, 2026
@dscho
[ports] msys2-runtime: enable pseudo consoles and empty values of env…
f1b4643 
… variables

This integrates the patches from
msys2/msys2-runtime#102 and from
msys2/msys2-runtime#101

Signed-off-by: Johannes Schindelin <[email protected]>

Source: msys2/MSYS2-packages@3dad035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dscho dscho dscho approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lazka @dscho @Geoffrey-A