fix: minor improvements (#2672)

kettanaito · web-flow · commit cd528734805a · 2026-03-16T23:17:02.000+01:00
diff --git a/src/core/handlers/GraphQLHandler.ts b/src/core/handlers/GraphQLHandler.ts
@@ -120,7 +120,7 @@ export function isDocumentNode(
 }
 
 function isDocumentTypeDecoration(
-  value: any,
+  value: unknown,
 ): value is DocumentTypeDecoration<any, any> {
   return value instanceof String
 }
diff --git a/src/core/sse.ts b/src/core/sse.ts
@@ -333,7 +333,7 @@ class ServerSentEventClient<
     }
 
     if (message.event) {
-      frames.push(`event:${message.event?.toString()}`)
+      frames.push(`event:${message.event.toString()}`)
     }
 
     if (message.data != null) {
diff --git a/src/core/utils/internal/parseGraphQLRequest.ts b/src/core/utils/internal/parseGraphQLRequest.ts
@@ -84,7 +84,7 @@ function extractMultipartVariables<VariablesType extends GraphQLVariables>(
 
       for (const path of paths) {
         if (!(path in target)) {
-          throw new Error(`Property '${paths}' is not in operations.`)
+          throw new Error(`Property '${path}' is not in operations.`)
         }
 
         target = target[path]
diff --git a/src/core/utils/internal/parseMultipartData.ts b/src/core/utils/internal/parseMultipartData.ts
@@ -62,7 +62,9 @@ export function parseMultipartData<T extends DefaultRequestMultipartBody>(
     return undefined
   }
 
-  const boundaryRegExp = new RegExp(`--+${boundary}`)
+  const boundaryRegExp = new RegExp(
+    `--+${boundary.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')}`,
+  )
   const fields = data
     .split(boundaryRegExp)
     .filter((chunk) => chunk.startsWith('\r\n') && chunk.endsWith('\r\n'))
diff --git a/src/core/ws/WebSocketIndexedDBClientStore.ts b/src/core/ws/WebSocketIndexedDBClientStore.ts
@@ -56,8 +56,7 @@ export class WebSocketIndexedDBClientStore implements WebSocketClientStore {
       promise.resolve(request.result)
     }
     request.onerror = () => {
-      // eslint-disable-next-line no-console
-      console.log(request.error)
+      console.error(request.error)
       promise.reject(
         new Error(
           `Failed to get all WebSocket clients. There is likely an additional output above.`,
diff --git a/test/browser/ws-api/ws.clients.browser.test.ts b/test/browser/ws-api/ws.clients.browser.test.ts
@@ -44,23 +44,19 @@ test('returns the number of active clients in the same runtime', async ({
   })
 
   // Must return 1 after a single client joined.
-  expect(
-    await page.evaluate(() => {
-      return window.link.clients.size
-    }),
-  ).toBe(1)
+  await expect(
+    page.waitForFunction(() => window.link.clients.size === 1),
+  ).resolves.toBeTruthy()
 
   await page.evaluate(async () => {
     const ws = new WebSocket('wss://example.com')
     await new Promise((done) => (ws.onopen = done))
   })
 
   // Must return 2 now that another client has joined.
-  expect(
-    await page.evaluate(() => {
-      return window.link.clients.size
-    }),
-  ).toBe(2)
+  await expect(
+    page.waitForFunction(() => window.link.clients.size === 2),
+  ).resolves.toBeTruthy()
 })
 
 test('returns the number of active clients across different runtimes', async ({
@@ -94,17 +90,25 @@ test('returns the number of active clients across different runtimes', async ({
     await new Promise((done) => (ws.onopen = done))
   })
 
-  expect(await pageOne.evaluate(() => window.link.clients.size)).toBe(1)
-  expect(await pageTwo.evaluate(() => window.link.clients.size)).toBe(1)
+  await expect(
+    pageOne.waitForFunction(() => window.link.clients.size === 1),
+  ).resolves.toBeTruthy()
+  await expect(
+    pageTwo.waitForFunction(() => window.link.clients.size === 1),
+  ).resolves.toBeTruthy()
 
   await pageTwo.bringToFront()
   await pageTwo.evaluate(async () => {
     const ws = new WebSocket('wss://example.com')
     await new Promise((done) => (ws.onopen = done))
   })
 
-  expect(await pageTwo.evaluate(() => window.link.clients.size)).toBe(2)
-  expect(await pageOne.evaluate(() => window.link.clients.size)).toBe(2)
+  await expect(
+    pageTwo.waitForFunction(() => window.link.clients.size === 2),
+  ).resolves.toBeTruthy()
+  await expect(
+    pageOne.waitForFunction(() => window.link.clients.size === 2),
+  ).resolves.toBeTruthy()
 })
 
 test('broadcasts messages across runtimes', async ({
@@ -198,7 +202,9 @@ test('clears the list of clients when the worker is stopped', async ({
   })
 
   // Must return the number of joined clients.
-  expect(await page.evaluate(() => window.link.clients.size)).toBe(1)
+  await expect(
+    page.waitForFunction(() => window.link.clients.size === 1),
+  ).resolves.toBeTruthy()
 
   await page.evaluate(() => {
     window.worker.stop()
@@ -239,7 +245,9 @@ test('clears the list of clients when the page is reloaded', async ({
   })
 
   // Must return the number of joined clients.
-  expect(await page.evaluate(() => window.link.clients.size)).toBe(1)
+  await expect(
+    page.waitForFunction(() => window.link.clients.size === 1),
+  ).resolves.toBeTruthy()
 
   await page.reload()
   await enableMocking()

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ export function isDocumentNode(`
`120`	`120`	`}`
`121`	`121`
`122`	`122`	`function isDocumentTypeDecoration(`
`123`		`- value: any,`
	`123`	`+ value: unknown,`
`124`	`124`	`): value is DocumentTypeDecoration<any, any> {`
`125`	`125`	`return value instanceof String`
`126`	`126`	`}`
Original file line number	Diff line number	Diff line change
`@@ -333,7 +333,7 @@ class ServerSentEventClient<`
`333`	`333`	`}`
`334`	`334`
`335`	`335`	`if (message.event) {`
`336`		- frames.push(`event:${message.event?.toString()}`)
	`336`	+ frames.push(`event:${message.event.toString()}`)
`337`	`337`	`}`
`338`	`338`
`339`	`339`	`if (message.data != null) {`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ function extractMultipartVariables<VariablesType extends GraphQLVariables>(`
`84`	`84`
`85`	`85`	`for (const path of paths) {`
`86`	`86`	`if (!(path in target)) {`
`87`		- throw new Error(`Property '${paths}' is not in operations.`)
	`87`	+ throw new Error(`Property '${path}' is not in operations.`)
`88`	`88`	`}`
`89`	`89`
`90`	`90`	`target = target[path]`