fix(ClientRequest): remove the fallback Agent if the request option agent is undefined#731
Merged
kettanaito merged 3 commits intomainfrom Jul 17, 2025
Merged
fix(ClientRequest): remove the fallback Agent if the request option agent is undefined#731kettanaito merged 3 commits intomainfrom
Agent if the request option agent is undefined#731kettanaito merged 3 commits intomainfrom
Conversation
kettanaito
approved these changes
Jul 17, 2025
Member
kettanaito
left a comment
kettanaito
left a comment
There was a problem hiding this comment.
Looks fantastic. Thank you!
kettanaito
changed the title
Agent if the request option agent is undefined
Member
Released: v0.39.3 🎉This has been released in v0.39.3! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
This was referenced Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#722 (comment)
mswjs/msw#1600
nock/nock#2839
Changes
Removes the custom logic that manually created a fallback HTTP Agent for the scenarios when
RequestOptions.agentwasundefined. That does not seem to be needed anymore (or at all).