fix(BatchInterceptor): remove listeners between fast refresh#262
Closed
kettanaito wants to merge 2 commits intomainfrom
Closed
fix(BatchInterceptor): remove listeners between fast refresh#262kettanaito wants to merge 2 commits intomainfrom
kettanaito wants to merge 2 commits intomainfrom
Conversation
kettanaito
commented
Jun 15, 2022
| * @see https://github.com/mswjs/msw/issues/1271 | ||
| */ | ||
| for (const interceptor of this.interceptors) { | ||
| interceptor['emitter'].pruneListeners() |
Member
Author
There was a problem hiding this comment.
Gotcha
Coupling internal _events pruning and .removeAllListeners() causes issues. Looks like we cannot remove the internal record all the time when the consumer removes listeners.
I'm adding a designated method that'd do both only in this particular scenario.
4 tasks
kettanaito
force-pushed
the
fix/fast-refresh
branch
from
d06677c to
18ba021
Compare
kettanaito
commented
Jun 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Roadmap
BatchInterceptor. Always attach listeners to the batch interceptor. Maybe because of this accept class references and not instances?