Enable samply to run on Android#76
Merged
Merged
Conversation
added 2 commits
November 7, 2023 12:36
Android is pretty much `linux` but needs to be enabled in the `target_os` guards. Tested on a headless Android 9 with 5.4.
Owner
|
Thanks! I'll fix the clippy failures on main and then you can rebase. |
Owner
|
Can you check how hard it would be to add CI for this configuration? Without CI it's likely to break in the future. |
Contributor
Author
|
Thanks. Regarding CI: sure - I've had the combination GH actions + target aarch64-ilnux-android a couple of times. I'll prepare a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android is pretty much
linuxbut needs to be enabled in thetarget_osguards. Tested on a headless Android 9 with 5.4.