Add --profile-name to record command#68
Merged
Merged
Conversation
Owner
|
This is an excellent idea. |
Contributor
Author
|
I fixed the one mac os compiler error I got on CI, hopefully there wasnt more hiding behind the next stage of compilation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
--profile-nameoption to the record command that sets the "product" field in the output json so that the name in the top left hand corner of the profiler UI is set to the provided value.I run a script that profiles my application under various scenarios and then opens all the results in my browser.
Currently the name in the corner is just set to the pid of the process which does not allow me to distinguish which tab corresponds to which scenario.
This PR fixes that.
Hovering over the profile name in the UI yields a tooltip "Edit the profile name".
So I think
--profile-nameis definitely the best name to expose to usersExample:
Marked as draft for now to see if mac os passes CI.