Add ipv6 support for server and client.#98
Closed
mattcarr1011 wants to merge 1 commit intomsoulier:masterfrom
Closed
Add ipv6 support for server and client.#98mattcarr1011 wants to merge 1 commit intomsoulier:masterfrom
mattcarr1011 wants to merge 1 commit intomsoulier:masterfrom
Conversation
Pass in a parameter for the af_family Set the socket and address based on that parameter Adjust the recvfrom and sendto return types based on the parameter
shawgree
reviewed
Jul 22, 2019
| if readysock == self.sock: | ||
| log.debug("Data ready on our main socket") | ||
| buffer, (raddress, rport) = self.sock.recvfrom(MAX_BLKSIZE) | ||
| if self.af_family == socket.AF_INET: |
There was a problem hiding this comment.
I think this should be 'af_family' and not 'self.af_family'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass in a parameter for the af_family
Set the socket and address based on that parameter
Adjust the recvfrom and sendto return types based on the parameter