Fix memory reporting (RSS vs vsize confusion) and oracle cache size overflow#804
Merged
msoos merged 3 commits intoworking-on-synthfrom Mar 11, 2026
Merged
Fix memory reporting (RSS vs vsize confusion) and oracle cache size overflow#804msoos merged 3 commits intoworking-on-synthfrom
msoos merged 3 commits intoworking-on-synthfrom
Conversation
Merged
…nd dead code Co-authored-by: msoos <[email protected]>
Co-authored-by: msoos <[email protected]>
Copilot
AI
changed the title
[WIP] Fix issues with synth implementation
Fix memory reporting (RSS vs vsize confusion) and oracle cache size overflow
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
time_mem.hrefactoring splitmemUsedTotal(double&)intomem_used(double&)(returns RSS) andmemUsedTotal()(returns vsize), but several call sites were updated incorrectly.Memory reporting bugs
dump_memory_stats_to_sql():mem_used()resolves toSolver::mem_used()(internal accounting) instead of system RSS — SQL "rss" metric was completely wrongprint_mem_stats():memUsedTotal()returns vsize, not RSS — all "Accounted for mem (rss)" percentages used wrong denominatorprint_norm_stats(): Same vsize/RSS confusion, plusmax_mem_usage(VmHWM) was never populated, making the else branch dead codeoccsimplifier.cpp:memUsedTotal()used where RSS was intendedAdded
rss_mem_used()totime_mem.h(all platforms) to provide RSS without a dummy output parameter, avoiding theSolver::mem_used()name collision.Oracle cache size overflow
Changed
max_cache_sizetosize_tso the multiplication promotes correctly.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.