Fix 3 bugs: duplicate safe_div, oracle cache sort truncation, lits_rem accumulation#803
Merged
msoos merged 2 commits intoworking-on-synthfrom Mar 11, 2026
Merged
Fix 3 bugs: duplicate safe_div, oracle cache sort truncation, lits_rem accumulation#803msoos merged 2 commits intoworking-on-synthfrom
msoos merged 2 commits intoworking-on-synthfrom
Conversation
Merged
… accumulation Co-authored-by: msoos <[email protected]>
Copilot
AI
changed the title
[WIP] Fix issues in synth functionality
Fix 3 bugs: duplicate safe_div, oracle cache sort truncation, lits_rem accumulation
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review of the synth PR surfaced three bugs.
Duplicate
safe_divinreducedb.cpp:safe_divwas moved toconstants.hbut the old copy inreducedb.cpp(insidenamespace CMSat) was not removed. Both definitions coexist sincereducedb.cppincludesconstants.h.Integer truncation in oracle cache sort comparator (
oracle.cpp): The sort lambda for selecting the best cache lookup variable assigned adoubleproduct touint64_t, truncating the fractional part. Sinceoccs[a]ranges 0.0–0.5, most values truncate to 0, making the sort effectively random.lits_remnot accumulated inoracle_vivif(oracle_use.cpp): Used=instead of+=, so only the last shortened clause's removal count was reported.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.