BUGFIX - Remove with_metaclass method#9
Merged
msiemens merged 1 commit intomsiemens:masterfrom May 22, 2020
dinkopehar:master
Merged
BUGFIX - Remove with_metaclass method#9msiemens merged 1 commit intomsiemens:masterfrom dinkopehar:master
msiemens merged 1 commit intomsiemens:masterfrom
dinkopehar:master
Conversation
Owner
|
Thanks for your pull request! I've merged it and will release a new version of |
Contributor
Author
|
Great ! I'm glad this got resolved well |
|
Thanks very much! |
Owner
|
tinydb-serialization v2.0.0 has been published which supports TinyDB v4 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull references this issue.
If I understood your code correctly,
with_metaclassis method for compatibility between python 2 and python 3 for creating meta classes.Since it's removed from TinyDB (v4.0.0), I refactored code, and run unit tests successfully. If I made a mistake or did something wrong, please notify me. Thank you.