Repository navigation
Conversation
When convert targets msgspec.Raw but the input is an already-parsed Python object (as with yaml/toml decode), raise a clear ValidationError instead of a confusing "Expected `any`, got `int`" message. Document that delayed decoding with Raw requires json or msgpack. Fixes msgspec#1136
Co-authored-by: Copilot Autofix powered by AI <[email protected]>
Author
|
Fork workflow runs need maintainer approval ( |
Siyet
reviewed
Sep 8, 2026
Contributor
There was a problem hiding this comment.
I found no correctness blocker for the field-value case in #1136. Please coordinate this change with #1155 and #1169:
- In #1155,
MS_TYPE_RAWis used for Raw, so thetype->types == 0condition will no longer match this type. Whichever PR is merged second will need an updated condition, preserving Raw/None union behavior. - String dictionary keys are handled through
convert_str()without a call toconvert(). Therefore, the error forconvert({"x": 1}, dict[msgspec.Raw, int])remainsExpected any, got strin this version. That diagnostic is corrected in #1169. The two fixes cover different execution paths.
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ValidationErrorwhenconverttargetsmsgspec.Rawbut receives an already-parsed Python object (as happens withyaml.decode/toml.decode)msgspec.Rawrequires the nativejsonormsgpackdecodersFixes #1136
Root cause
msgspec.Rawrequires substrings of the original serialized bytes. The nativejsonandmsgpackdecoders capture these via*_decode_raw(). Theyamlandtomlmodules parse messages fully with PyYAML/tomllib before callingconvert, so the original byte spans are unavailable.Previously,
convertdispatched on the source Python type and produced a confusing error likeExpected \any`, got `int``.Test plan
test_raw_from_parsed_object_errorintest_convert.pytest_decode_raw_field_unsupportedintest_yaml.py