Backport type annotation syntax support for older python versions #771

Activity

1. jcrist commented on Nov 15, 2024

   

   jcrist

   on Nov 15, 2024

   MemberAuthor

   More actions

   A few options I see here:

   • Do as pydantic does (use eval_type_backport if installed, error otherwise and suggest the user install it). This keeps it as an optional dependency.
   • Add it as a mandatory dependency for older python versions. This would be our first mandatory dependency though, so I'm -0.5 on that.
   • Write our own implementation (looking at their code, I think there's a simpler way we could add support here). Downside here is this is all hacks and it'd be hacks we'd maintain rather than someone else.

   I'd be open to either option 1 or 3. Thoughts @ashb? Is this something you'd be interested in contributing?
2. ashb commented on Nov 15, 2024

   

   ashb

   on Nov 15, 2024

   Contributor

   More actions

   In terms of effort I can spare l make time to do no.1, not sure I've got the spare cycles to do a full implementation.

   Happy to pr approach 1

   👍React with 👍1Reacted by Jim Crist-Harif
3. jcrist commented on Nov 15, 2024

   

   jcrist

   on Nov 15, 2024

   MemberAuthor

   More actions

   Sounds good to me, thanks!
4. ashb commented on Nov 15, 2024

   

   ashb

   on Nov 15, 2024

   Contributor

   More actions

   @jcrist Re testing: am I right in thinking that the cibuildwheel will test against multiple versions of python, so do I need to convice the GHA pipeline to run 3.9 with and without the dep installed?
5. jcrist commented on Nov 15, 2024

   

   jcrist

   on Nov 15, 2024

   MemberAuthor

   More actions

   There are ways to hack in testing without it I installed that wouldn't require another ci build - if you could just write tests for behavior with it installed I can add/fixup those afterward.

   ❤️React with ❤️1Reacted by Ash Berlin-Taylor
6. jcrist

   closed this as completedin #773on Dec 27, 2024