Encoding exceptions - segfault #727

Activity

1. provinzkraut commented on Aug 28, 2024

   

   provinzkraut

   on Aug 28, 2024

   Last edited by provinzkraut

   Member

   More actions

   I usually do something like this:

   class EncodableException(Exception):
     def to_dict(self) -> dict[str, Any]:
      ...
   
   
   def enc_hook(value: Any) -> Any:
     if isinstance(value, EncodableException):
       return value.to_dict()
     raise TypeError()

   and then use this enc_hook whenever I'm encoding stuff that might contain one of those exceptions.

   👍React with 👍1Reacted by Jim Crist-Harif
2. msgspec

   deleted a comment from on Aug 28, 2024
3. jcrist

   closed this as completedin #745on Oct 14, 2024
4. jcrist commented on Oct 14, 2024

   

   jcrist

   on Oct 14, 2024

   Member

   More actions

   Thanks for opening this. In prior versions msgspec had a check preventing mixing Struct classes with other builtin types - this check was broken on Python 3.12 but is now fixed in #745. The above example now errors nicely rather than segfaulting. If you want to encode exceptions I recommend following a pattern like the one @provinzkraut outlined above rather than defining an Exception type that is also a Struct.