UnboundLocalError for new_scope #625

Activity

1. treykeown commented on Jan 4, 2024

   

   treykeown

   on Jan 4, 2024

   Last edited by treykeown

   Author

   More actions

   import msgspec
   from typing import Generic, TypeVar
   
   T = TypeVar('T')
   T_int = TypeVar('T_int', bound=int)
   
   class Base(msgspec.Struct, Generic[T], tag=True):
       """..."""
   
   
   class Subclass(Base[int]):
       """..."""
   
   
   class Bug(Subclass, Base[T_int], Generic[T_int]):
       """..."""
   
   
   if __name__ == "__main__":
       enc = msgspec.msgpack.encode(Bug())
       dec = msgspec.msgpack.decode(enc, type=list[Bug])
       print(dec)

   Traceback (most recent call last):
     File "/Users/.../scratch.py", line 21, in <module>
       dec = msgspec.msgpack.decode(enc, type=list[Bug])
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/Users/.../.venv/lib/python3.12/site-packages/msgspec/_utils.py", line 113, in get_class_annotations
       mro, typevar_mappings = _get_class_mro_and_typevar_mappings(obj)
                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     File "/Users/.../.venv/lib/python3.12/site-packages/msgspec/_utils.py", line 90, in _get_class_mro_and_typevar_mappings
       inner(obj, {})
     File "/Users/.../.venv/lib/python3.12/site-packages/msgspec/_utils.py", line 88, in inner
       inner(b, new_scope)
     File "/Users/.../.venv/lib/python3.12/site-packages/msgspec/_utils.py", line 88, in inner
       inner(b, new_scope)
                ^^^^^^^^^
   UnboundLocalError: cannot access local variable 'new_scope' where it is not associated with a value
   
2. treykeown commented on Jan 4, 2024

   

   treykeown

   on Jan 4, 2024

   Author

   More actions

   I've since fixed how my classes are structured, but this is still an issue any time a generic class appears both in a parent class and in a child class.
3. jcrist commented on Jan 5, 2024

   

   jcrist

   on Jan 5, 2024

   Member

   More actions

   Thanks for the excellent reproducible issue, this should be fixed by #626.
4. jcrist

   closed this as completedin #626on Jan 5, 2024