Repository navigation
Bug: fields API does not support generic Structs if the type is specified #570
Description
Description
The msgspec.structs.fields API does not support generic types if the type is specified as seen below:
from typing import Generic, TypeVar
from msgspec import Struct
from msgspec.structs import fields
T = TypeVar("T")
class GenericFoo(Struct, Generic[T]):
foo: T
generic_foo_fields = fields(GenericFoo) # does not fail
generic_foo_fields = fields(GenericFoo[int]) # failsThe reason for this is that isinstance(GenericFoo[int], type) will return False.
Activity
jcrist commentedon Oct 17, 2023
Thanks for the issue, this is resolved in #571.
vkcku commentedon Oct 18, 2023
Thank you so much for such fast fixes :)