Repository navigation
Allow date, datetime, time for ge, gt, le, lt #482
Description
Description
Currently the ge, gt, le, lt constraints are limited to ints and floats, but dates, datetimes and times are comparable as well:
now = datetime.now(timezone.utc)
yesterday = now - timedelta(days=1)
tomorrow = now + timedelta(days=1)
assert yesterday <= now <= tomorrow # TrueThis would enable constraints like:
class Event(Struct):
from_date: Annotated[datetime, msgspec.Meta(gt=...)]
to_date: Annotated[datetime, msgspec.Meta(gt=...)]Reacted by Simon Wienhöfer, febkor, 叶子 and Jack McIvor
Reacted by 叶子 and Jack McIvor
Activity
jcrist commentedon Jul 13, 2023
Thanks for opening this, this is definitely a feature that makes sense to add. Tossing it on the todo list.
alexei commentedon Jul 13, 2023
Out of curiosity, do these constraints need to be implemented for each type? I was looking over the list of supported types and realized decimals, strings and UUIDs can be compared as well, and just about anything that implements the comparison magic methods.
jcrist commentedon Jul 13, 2023
Currently yes. For ints/floats a type-specific implementation can be much more efficient than a generic one.
For more complicated types like uuids/decimals/... there may be negligible benefits for implementing them in native code; we might be better served by using a generic implementation here.
FHU-yezi commentedon Jan 22, 2025
Wonder this feaature become true.