Show only non-defaults when omit_defaults is set #309

Activity

1. jcrist commented on Feb 10, 2023

   

   jcrist

   on Feb 10, 2023

   Member

   More actions

   Can you say more about why you'd want that behavior? What's your use case?

   I'm not sure coupling a simpler repr to omit_defaults makes sense (omit_defaults is about encoding, not repr-ing). I'd thought about omitting default values from the repr for all structs, but nixed it since neither dataclasses, attrs, nor pydantic do this.
2. rsmb7z commented on Feb 10, 2023

   

   rsmb7z

   on Feb 10, 2023

   Author

   More actions

   Hi @jcrist
   Yes I understand that omit_defaults is specific to encoding originally however having different flag will be okay too.
   Similar to performance improvment with omit_defaults during encoding, I would prefer to view only arguments which are non-defaults. Expected behavior you will find here for Contract class.
   https://github.com/erdewit/ib_insync/blob/master/ib_insync/contract.py
3. jcrist

   closed this as completedin #322on Feb 16, 2023
4. jcrist commented on Feb 16, 2023

   

   jcrist

   on Feb 16, 2023

   Member

   More actions

   I've added a new repr_omit_defaults option in #322 that should do what you want.

   🚀React with 🚀2Reacted by rsmb7z and Tin Tvrtković
5. ml31415 commented on Mar 30, 2024

   

   ml31415

   on Mar 30, 2024

   More actions

   This new option should probably be mentioned in the docs on the website as well.