Skip to content

Support JDK17 #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xerial merged 4 commits into from
Jun 28, 2022
Merged

Support JDK17 #660

xerial merged 4 commits into from
Jun 28, 2022
+96 −21

Conversation

@xerial
Copy link
Member

@xerial xerial commented Jun 28, 2022 •
edited
Loading

To use JDK17 + DirectByteBuffer, we need to set two JVM options:

--add-opens=java.base/java.nio=ALL-UNNAMED
--add-opens=java.base/sun.nio.ch=ALL-UNNAMED

This PR adds:

  • CI for JDK17
  • Add a workaround even if these JVM options are not set.
  • Add a warning message when DirectByteBuffer is used in JDK17 without setting these JVM options

Related approaches:

Fixes #600

@xerial xerial marked this pull request as ready for review June 28, 2022 09:28
@xerial xerial merged commit 117f161 into develop Jun 28, 2022
@xerial xerial mentioned this pull request Jun 28, 2022
Open
@akudiyar akudiyar mentioned this pull request Jan 2, 2024
Closed
@xerial xerial deleted the jdk17-support branch July 19, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Not working in 17 JDK

2 participants

@xerial