Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the build infrastructure and codebase for 2025, updating Go version requirements and refactoring the core scanning functionality to use Go's fs.FS interface for better testability and abstraction.
- Updates Go version from 1.17 to 1.24 and modernizes CI/CD workflows
- Refactors scanning functionality to use
fs.FSinterface instead of direct filesystem access - Updates build configuration and release processes with latest tooling
Reviewed Changes
Copilot reviewed 10 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updates Go version requirement from 1.17 to 1.24 |
| main.go | Refactors to use fs.FS interface and updates import paths |
| internal/deepclean/scan.go | Core refactoring to use fs.FS interface and modernizes code patterns |
| internal/deepclean/scan_test.go | Updates tests to work with new fs.FS interface |
| .goreleaser.yml | Modernizes release configuration to version 2 format |
| .github/workflows/*.yml | Updates CI/CD workflows with latest actions and security features |
| Makefile | Simplifies build process and removes outdated comments |
| README.md | Updates installation instructions for homebrew tap |
| .github/SECURITY.md | Adds security policy documentation |
Comments suppressed due to low confidence (1)
go.mod:3
- Go version 1.24 does not exist. The latest stable Go version as of January 2025 was 1.23. Please use a valid Go version like '1.23' or check the current stable release.
go 1.24
These are likely I/O bound, and concurrency is more to provide "snappy" feeling streaming results by not having a large directory hold up all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the build mechanics (and making a few small cleanups at the same time).