Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mroth/deepclean
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.2
Choose a base ref
...
head repository: mroth/deepclean
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.3.0
Choose a head ref
  • 5 commits
  • 8 files changed
  • 1 contributor

Commits on Apr 22, 2023

  1. chore(deps): update dependencies

    @mroth
    mroth committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    e2de631 View commit details
    Browse the repository at this point in the history

  2. chore(ci): update test workflow

    @mroth
    mroth committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    c57a503 View commit details
    Browse the repository at this point in the history

  3. feat: replace github.com/karrick/godirwalk. with filepath.WalkDir 

    TLDR the state of the art for performant directory walking has changed
in more modern versions of Go:

https://engineering.kablamo.com.au/posts/2021/quick-comparison-between-go-file-walk-implementations/

With this change, things are indeed faster on my current laptop, and we
get rid of a dependency.

hyperfine -w1 "bin/deepclean ~/src" "bin/deepclean-main ~/src"
Benchmark 1: bin/deepclean ~/src
  Time (mean ± σ):     241.0 ms ±   3.8 ms    [User: 113.6 ms, System: 682.3 ms]
  Range (min … max):   233.8 ms … 246.1 ms    12 runs

Benchmark 2: bin/deepclean-main ~/src
  Time (mean ± σ):     356.9 ms ±   2.8 ms    [User: 162.2 ms, System: 913.8 ms]
  Range (min … max):   353.5 ms … 361.6 ms    10 runs

Summary
  'bin/deepclean ~/src' ran
    1.48 ± 0.03 times faster than 'bin/deepclean-main ~/src'
    @mroth
    mroth committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    2e3ce54 View commit details
    Browse the repository at this point in the history

  4. chore(ci): add dependabot scanning

    @mroth
    mroth committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    8148ab8 View commit details
    Browse the repository at this point in the history

  5. chore(ci): update release workflow

    @mroth
    mroth committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    0325d17 View commit details
    Browse the repository at this point in the history
Loading