Skip to content

merge master#1

Merged
mrkstwrt merged 23 commits intomrkstwrt:masterfrom
fastify:master
Mar 11, 2019
Merged

merge master#1
mrkstwrt merged 23 commits intomrkstwrt:masterfrom
fastify:master

Conversation

@mrkstwrt
Copy link
Copy Markdown
Owner

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

mcollina and others added 23 commits February 28, 2019 19:32
* fix: unused shared schema to serializer

* add: details on bool check
* docs: add first draft fluent-schema

* docs: add reuse usage

* add: fluent-schema tests

* docs: write more info and align with tests

* fix: skip fluent-schema test with node < 8

* add: better described enum
* add ip, ips and hostname in fastify's request obj

* refactor based on @nwoltman comments in 88f4c8a

* add descriptions to ip, ips, and hostname in Request README

* store ip as a variable for later use

* add the new property, ips in Request

* refactor trust proxy handling logic -> it doesn't allocate new object

* change ips' type to string[] to match proxyAddr.all output

* refactor: make a const to the outer scope and update the references

* add a test of x-forwarded-host before setting it to hostname

* add ip, ips and hostname back to the Node req object.

* refactor: make the comment 1 line

* keep previous assertions

* add addPropertiesToNodeReq to options for ip, ips, hostname, log

* refactor: use logger from Fastify's log instead of from `reply.res`

* add a test case for addPropertiesToNodeReq that mirrors trust proxy test

* add modifyCoreObjects to ServerOptions type

* change the option name to modifyCoreObjects

* make modifyCoreObjects optional in the type and add it to types test

* change addPropertiesToNodeReq to modifyCoreObjects
Also update the relevant documentation to be clearer about how the properties should be accessed and fix some typos.
Adjusted the docs on errors as discussed in #1514

#### Checklist

- [x] documentation is changed or added
- [x] commit message and code follows [Code of conduct](https://github.com/fastify/fastify/blob/master/CODE_OF_CONDUCT.md)
* Added fastify-mongoose-driver to Community Plugins

* Updated documentation for avvio PR 82 & fastify issue 1489

* Removed plugin

* Updated Plugins-Guide.md according to comments

* Update docs/Plugins.md

Co-Authored-By: alex-ppg <[email protected]>

* Updated Plugins.md to reflect comments

* Added test suites for avvio change

* Added more tests for avvio plugin change

* Updated plugin.test.js again

* Updated documentation reflecting avvio change

* Added another test for plugin.test.js

* Updated plugin.test.js adding decorate test on fp

* Updated documentation to reflect behavior of instance in register options

* Plugin test update to reflect encapsulation, variable rename
* Add res serializer

* Minor refactor

* Address change request
* initialConfig - second draft

address #1444 with changes requested here #1465 (comment)

* fix typo

* Test fix and little code rework

* Code refactor

* Improve test coverage

* Fix code and add one more test

* Fix

* Add deep cloning through `rfdc`

* Fix test and expected behavior

* Fix test on Node.js 6

* Fix code and test

* Fix: from `let` to `const`

* Fix: Better `TypedArray` detection.

This will avoid any TypeError and cover all the cases.

*Previously it only covered `Uint8Array` because `Buffer` are instances of `Uint8Array` since Node.js 4*
ref.: https://nodejs.org/docs/latest-v4.x/api/buffer.html#buffer_buffer

* Add a test with Pino.js stream option.

* Fix: Improve Pino.js stream test.

* Fix: add a new internal error code.

* Fix: remove uneeded error statusCode.

* Fix: should expose default init options.

* Fix typo.

* Achieve 100 % code coverage and export utils.
@mrkstwrt mrkstwrt merged commit a358039 into mrkstwrt:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.