Repository navigation
Commit a225ec4
committed
[refactor](be) Check cancellation before each window peer fill
### What problem does this PR solve?
Issue Number: None
Related PR: apache#68500
Problem Summary: Window spill peer replay fills a constant result for each
peer/output intersection, but retained row-based cancellation checks by
splitting fills at 4096-row boundaries. Check cancellation before each fill
instead and let the peer and output boundaries determine the fill size.
Replay output is already bounded by the runtime batch size. Add unit coverage
for cancellation before filling, a large peer filled without artificial row
splits, and cancellation between uneven peers. SQL results are unchanged.
### Release note
None
### Check List (For Author)
- Test: Unit test compilation and ASAN BE build
- Unit Test: Added two focused peer-fill tests. The modified source and test translation units compiled through run-be-ut.sh, but test execution was blocked by existing function_string_test.cpp compilation errors.
- Manual test: ASAN ./build.sh --be -j16, clang-format v16, build hygiene, and git diff --check passed. clang-tidy was attempted but blocked by the toolchain's missing stddef.h resource header.
- Regression test: Not run for this cancellation-check refactoring.
- Behavior changed: Yes (check cancellation before each peer/output fill instead of every 4096 output rows; SQL results unchanged).
- Does this need documentation: No.1 parent af6a803 commit a225ec4
2 files changed
Lines changed: 59 additions & 6 deletions
File tree
- be
- src/exec/operator
- test/exec/operator
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
432 | 432 | | |
433 | 433 | | |
434 | 434 | | |
435 | | - | |
436 | | - | |
437 | | - | |
| 435 | + | |
438 | 436 | | |
439 | 437 | | |
440 | 438 | | |
441 | 439 | | |
442 | 440 | | |
443 | 441 | | |
444 | | - | |
445 | 442 | | |
446 | | - | |
447 | | - | |
| 443 | + | |
448 | 444 | | |
449 | 445 | | |
450 | 446 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
1709 | 1710 | | |
1710 | 1711 | | |
1711 | 1712 | | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
| 1739 | + | |
| 1740 | + | |
| 1741 | + | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
| 1747 | + | |
| 1748 | + | |
| 1749 | + | |
| 1750 | + | |
| 1751 | + | |
| 1752 | + | |
| 1753 | + | |
| 1754 | + | |
| 1755 | + | |
| 1756 | + | |
| 1757 | + | |
| 1758 | + | |
| 1759 | + | |
| 1760 | + | |
| 1761 | + | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
| 1765 | + | |
| 1766 | + | |
| 1767 | + | |
| 1768 | + | |
1712 | 1769 | | |
1713 | 1770 | | |
1714 | 1771 | | |
| |||
0 commit comments