Repository navigation
fix(installer): let --uninstall run when IDA Free is installed - #531
Merged
mrexodia merged 2 commits intoSep 21, 2026
Merged
Conversation
install_ida_plugin() checked for idafree_*.hexlic before looking at `uninstall`, so removing the plugin exited 1 with an install-only message and left every file in place. --allow-ida-free is documented as allowing *installation*, and an uninstall has no license dependency, so the guard belongs to the install path only.
Lesereingrape
had a problem deploying
to
external-pr
September 21, 2026 13:38 — with
GitHub Actions
Failure
mrexodia
requested changes
Sep 21, 2026
Removed at review: the change is a one-line guard in the uninstall path and the maintainer considers the test unnecessary.
Lesereingrape
had a problem deploying
to
external-pr
September 21, 2026 14:50 — with
GitHub Actions
Failure
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #530
Problem
install_ida_plugin()ran its IDA Free license check before it looked at theuninstallflag, soida-pro-mcp --uninstall— and--uninstall <client>,which aborts before
_apply_client_install()is ever reached — exited 1 with aninstall-only message and removed nothing.
--allow-ida-freeis documented as"Allow installation despite IDA Free being installed"
(
server.py:274-278), and removing files has no dependency on which license ispresent, so the guard can only ever belong to the install path.
The state is easy to reach:
--install --allow-ida-freeis exactly how a userwith an IDA Free license file in the IDA user directory is expected to install,
and every later cleanup attempt then fails.
Change
One token: the guard becomes
if not allow_ida_free and not uninstall:.Nothing else in the function moves, so installation still refuses to proceed
over an IDA Free license unless
--allow_ida_freeis passed; that control casewas measured before the test file was removed at review.
Measurements (Windows 11, Python 3.12.11, base
cae2fa8)Same interpreter, same command, base worktree vs this branch:
A throwaway
tests/test_installer_ida_free_uninstall.py(3 tests: removaldespite the license file, the install-refusal control, and
run_install_commandcontinuing to the client step) was measured on this branch's earlier head and
removed at review, so the
branch now carries the one-token guard change:
cae2fa8worktree:2 failed, 1 passed— both failures wereSystemExit: 1raised atinstaller.py:485, i.e. they failed on behaviour, not on a mock3 passedFull suite A/B:
cae2fa8:1 failed, 248 passed, 114 subtests passed1 failed, 251 passed, 114 subtests passedThe single failure in both runs is pre-existing and unrelated:
tests/test_mcp_spec_http_e2e.py::Http11TransportTests::test_single_threaded_stop_closes_idle_keepalive_connection.So the delta there was +3 tests and 0 new failures; on the current head the
delta is 0 tests and 0 new failures.
ruff check(0.14.0, repo config) reports All checks passed on the changedfile, and the same on
installer.pyat base.install_ida_pluginhas exactly one caller (run_install_command,installer.py:650), whichserver.py:330reaches from--install/--uninstall— verified with
grep -rn "install_ida_plugin", so the change cannot affect anyother entry point.
Relation to my other open PR
PR #529 also edits
installer.py, but only the transport-URL helpers aroundlines 140-215; this change touches line 479. The two
branches share no hunk and apply to
mainindependently, in either merge order.Note on CI
.github/workflows/idalib-tests.ymlis the only workflow and it runsida-mcp-testinside the IDA containers, notpytest tests, so this suite isnot exercised by CI. To run it without an IDA installation:
Both platform branches of
_get_ida_user_dir()feed the sameglobcheck, sothe behaviour is identical on Linux and macOS; only Windows was measured here.
Authorship disclosure
This PR was authored by an AI agent; no human reviewed the diff before
submission. All measurements above were executed and recorded by the agent on
the commits in this branch (1 file, +1/−1 after
9b1dcaaremoved the test fileat review).