Repository navigation
OBB: Fix applyMatrix4() with rotated boxes and negative determinants. - #35261
Merged
Merged
Conversation
Mugen87
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
OBB.applyMatrix4()had two problems:rotation.multiply()), so for an OBB that already has a non-identity rotation the result wasR_obb * R_matrixinstead ofR_matrix * R_obb. This went unnoticed because the OBB example only uses boxes with an identity rotation.sx(used to keep the extracted rotation proper) was also applied tohalfSize.x, leaving a negative half size.containsPoint()then always returnsfalse, andintersectsOBB()gives wrong results.This PR uses
premultiply(), applies the absolute value ofsxto the half size, and adds unit tests for both cases. The new tests fail without the fix.