Repository navigation
Line, Points: Copy morph targets in copy(). - #35147
Merged
Mugen87 merged 1 commit intoOct 22, 2026
Merged
Conversation
📦 Bundle sizeFull ESM build including core, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
🖼️ E2E screenshot tests❌ 1 example(s) failed (full artifacts).
|
Mugen87
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
LineandPointsinitializemorphTargetInfluencesandmorphTargetDictionaryfrom their geometry, but unlikeMesh.copy(), theircopy()methods don't transfer them. A clonedLineorPointswith morph attributes ends up with both propertiesundefined, andWebGLRendererthen throwsTypeError: Cannot read properties of undefined (reading 'length')inWebGLMorphtargets.update().This PR copies both properties the same way
Mesh.copy()does, and adds acopy/morphTargetsunit test for each class.Tested with
npm test, and by rendering a clonedLineandPointswith morph attributes usingWebGLRendererin Chrome (throws before the change, renders after it).