Repository navigation
Docs: Drop JSDoc params the functions no longer take - #34226
Merged
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
approved these changes
Aug 13, 2026
This was referenced Aug 18, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reading
VarIntentand the block above it documents anameparameter, but the arrow function only takesnode. The one directly above it,Const, takes both, so the block looks like it got copied down and never trimmed. Went through the rest ofsrcafter that and three more turned up the same way.Switchcarries amethodparam fromElsesitting above it,setupDiffuseColordocumentsgeometrywhen it actually destructures that out of the builder it is given, and theBindGroupconstructor still documents anindexit does not take.Left alone the TSL factories, where the block sits over something like
nodeProxyIntent( MathNode, MathNode.ALL )and the documented names belong to the function being produced rather than to the call written underneath, and also the places where a parameter is commented out in the signature,getPropertyName( node/*, shaderStage*/ )and friends, since that reads as deliberate rather than stale.