TSLEncoder: Fix Fn layout generation when generating a function with no input parameters#32272
Merged
sunag merged 1 commit intomrdoob:devfrom Nov 15, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When generating a function that doesn't have any input parameters, the TSLEncoder emits an extraneous comma, causing the generated JavaScript to be invalid.
This PR fixes that by only emitting a comma if there is at least one input parameter to the function.
Example
Creating a function with no input parameters like this:
Causes the TSLEncoder to emit the following:
The second parameter to Fn (i.e, the function layout) has an invalidly placed comma before the
returnproperty.