Skip to content

RenderTarget: Fix copy of images. - #30585

Merged
Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev1
Feb 23, 2025
Merged

Mugen87 merged 1 commit into
mrdoob:devfrom
Mugen87:dev1

Conversation

@Mugen87

@Mugen87 Mugen87 commented Feb 22, 2025

Copy link
Copy Markdown
Collaborator

Fixed #30540.

Description

Second attempt of #30570, now with a note in the documentation.

@Mugen87
Mugen87 requested a review from gkjohnson February 22, 2025 10:15
@Mugen87 Mugen87 added this to the r174 milestone Feb 22, 2025
@github-actions

Copy link
Copy Markdown

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 336.65
78.39
336.65
78.39
+0 B
+0 B
WebGPU 522.23
144.94
522.23
144.94
+0 B
+0 B
WebGPU Nodes 521.7
144.84
521.7
144.84
+0 B
+0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.64
112.24
465.7
112.26
+55 B
+21 B
WebGPU 592.61
160.56
592.66
160.58
+55 B
+17 B
WebGPU Nodes 547.74
150
547.79
150.02
+55 B
+14 B

@gkjohnson gkjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Mugen87
Mugen87 merged commit 3bb6e70 into mrdoob:dev Feb 23, 2025
wowlegend added a commit to wowlegend/Crafty that referenced this pull request Aug 13, 2026
…ot landing tonight

Kevin authorised landing the upgrade if it works ("if the upgrade works, then do
it"), then went to sleep. It does not clear the bar I set before measuring, so it
is reverted and this is the record instead.

MEASURED, with a presence control, production bundle, identical 12s probe:
  three 0.172.0 + postprocessing 6.39.1  ->  6 glBlitFramebuffer messages
  three 0.174.0 + postprocessing 6.39.4  ->  0

The control is the point. A zero from an instrument never shown to produce a
non-zero is not evidence, and this repo has shipped that mistake seventeen times.

That confirms the upstream maintainer's theory on pmndrs/postprocessing#750: the
GL storm we had filed as a SEPARATE production-bundle finding and the GodRays
regression share a root cause in three r172's depth-texture handling
(mrdoob/three.js#30585, fixed r174).

A gap this exposed, worth more than the upgrade: prod-smoke.mjs CANNOT SEE this
error class. It filters on m.type() === 'error' and these arrive as 'warning', so
the repo's own production gate is structurally blind to the error storm it exists
to watch.

WHY IT IS NOT LANDING: r174 changes the whole look. 19 of 31 frames go over gate,
many at 99%+ local density, and the sky is visibly more saturated -- a global
colour/tone change, not one subsystem regressing. Landing it means rewriting all
31 baselines, which is a judgement about how the game should LOOK. That is
Kevin's call, not a correctness fix the loop can self-gate, and a bundled
engine-bump + re-baseline is precisely the shape baseline-trailer exists to stop.

It also runs against c1d933e, which deliberately blocks 0.x MINOR bumps for the
engine stack. This measurement is evidence FOR that policy.

Reverted fully: package.json + package-lock.json restored from backup, npm ci
re-run, 0.172.0 / 6.39.1 confirmed installed, tree clean.

The upstream reply is DRAFTED, NOT POSTED -- a public upstream comment is
outward-facing and stays Kevin's. It says plainly that I cannot yet confirm r174
fixes the SUN, because the global change makes that unseparable without a
controlled r174 pair I have not run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

depthTexture share source after RenderTarget.clone()

2 participants