Nodes: Add DenoiseNode.#28879
Merged
Mugen87 merged 2 commits intomrdoob:devfrom Jul 15, 2024
Merged
Conversation
Mugen87
commented
Jul 15, 2024
| const sampleNormal = ( uv ) => this.normalNode.uv( uv ); | ||
| const sampleNoise = ( uv ) => this.noiseNode.uv( uv ); | ||
|
|
||
| const getViewPosition = tslFn( ( [ screenPosition, depth ] ) => { |
Collaborator
Author
There was a problem hiding this comment.
This is the second pass where getViewPosition() is used. Now the time seems right to add a utility function somewhere as previously discussed in #28844.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Collaborator
Author
|
Sidenote: When creating an instance of |
This was referenced Jul 16, 2024
This was referenced Jul 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
This PR adds
DenoiseNodewhich is a port ofPoissonDenoiseShader. It can be used to improve the result of AO by smoothing out the noisy appearance of the default occlusion.I'll integrate it in the AO demo with a configurable GUI when #28863 is done.
GTAOPassmust return the raw AO soDenoiseNodecan be chained after it (but before the blend).For comparison:
With Denoise:
Without Denoise: