Skip to content

TeapotGeometry: Add Documentation#28633

Merged
Mugen87 merged 3 commits intomrdoob:devfrom
hongchristopher:documentteapotgeometry
Jun 15, 2024
Merged

TeapotGeometry: Add Documentation#28633
Mugen87 merged 3 commits intomrdoob:devfrom
hongchristopher:documentteapotgeometry

Conversation

@hongchristopher
Copy link
Copy Markdown
Contributor

@hongchristopher hongchristopher commented Jun 12, 2024

Related issue: #27034

Description

Adds a docs page for TeapotGeometry add-on.

@Mugen87
Copy link
Copy Markdown
Collaborator

Mugen87 commented Jun 12, 2024

  1. The new page needs to be added in https://github.com/mrdoob/three.js/blob/dev/docs/list.json.

  2. The default of fitLid is true. This needs to be corrected in the comment here:

three.js/examples/jsm/geometries/TeapotGeometry.js

Line 13 in 59ea902

* fitLid = false, blinn = true

Please include both changes in this PR.

@Mugen87 Mugen87 added this to the r166 milestone Jun 12, 2024
@Mugen87
Copy link
Copy Markdown
Collaborator

Mugen87 commented Jun 15, 2024

I'll merge and fix.

@Mugen87 Mugen87 merged commit b30ca1b into mrdoob:dev Jun 15, 2024
@Mugen87 Mugen87 mentioned this pull request Jun 15, 2024
Merged
@hongchristopher
Copy link
Copy Markdown
Contributor Author

hongchristopher commented Jun 16, 2024

Thanks for getting to this, I appreciate it.

@hongchristopher hongchristopher deleted the documentteapotgeometry branch June 16, 2024 03:14
This was referenced Jun 20, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r166

Development

Successfully merging this pull request may close these issues.

2 participants

@hongchristopher @Mugen87