-
-
Notifications
You must be signed in to change notification settings - Fork 36.2k
Nodes: Rename invert() -> oneMinus() #25725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think it's better to remain it |
Hmm... I also like the term invert(). My concern is that the others popular NodesGraph use this term: |
|
Maybe @mrdoob has some suggestions? |
|
I think it's better to follow the terms used in other node editors. So OneMinus 👍 |
|
Maybe we can have alias |
|
@sunag Why we cannot have |
I think const number = float( 90 )
const result = number.invert( 100 ); // result is 10 ( 100 - 90 )
// -> .invert() // default is 1
const number = float( .9 )
const result = number.invert(); // result is 0.1 ( 1.0 - 0.9 )
//
number.invert( -1 ) // for negative numbers |
|
It wouldn't be invert then... Maybe then it is better to remain as it is. |
Description
It seems to be the most common term.